fix(circom): reuse compressed public key in V1 challenge - #153
Open
wj00243-lgtm wants to merge 1 commit into
Open
wj00243-lgtm wants to merge 1 commit into
wj00243-lgtm wants to merge 1 commit into
Conversation
wj00243-lgtm
marked this pull request as ready for review
May 20, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14
Problem
The V1 circuit compressed the public key twice: once for the hash-to-curve preimage and once again while building the V1 challenge hash preimage.
Solution
This exposes the already computed compressed public key from check_ec_equations and reuses it in the V1 challenge SHA-256 helper. The challenge preimage bytes stay the same, but the circuit avoids a duplicate public-key compression component.
Tests
I could not run the full local circuit suite in this environment because pnpm install fails while fetching https://gitpkg.now.sh/geometryresearch/secp256k1_hash_to_curve/circuits?main with HTTP 402. The local Node version is also v24.15.0 while this package declares >=16 <19.